Skip to content

feat: refactor setTssTag #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

feat: refactor setTssTag #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 2 additions & 6 deletions src/mpcCoreKit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@ export class Web3AuthMPCCoreKit implements ICoreKit, IMPCContext {
public getTssShare(args: { keyType: KeyType; factorkey: BN; accountIndex?: number }) {
const { keyType, factorkey, accountIndex } = args;
return this.tkey.getTSSShare(factorkey, {
tssTag: TSS_TAG_DEFAULT,
keyType,
accountIndex: accountIndex === undefined ? this.state.accountIndex : accountIndex,
});
Expand Down Expand Up @@ -764,7 +763,7 @@ export class Web3AuthMPCCoreKit implements ICoreKit, IMPCContext {
* Get public key point.
*/
public getPubKeyPoint(keyType: KeyType, accountIndex?: number): Point {
const tssPubKey = this.tkey.getTSSPub(keyType, TSS_TAG_DEFAULT, accountIndex === undefined ? this.state.accountIndex : accountIndex);
const tssPubKey = this.tkey.getTSSPub(keyType, accountIndex === undefined ? this.state.accountIndex : accountIndex);
return tssPubKey;
}

Expand Down Expand Up @@ -967,7 +966,7 @@ export class Web3AuthMPCCoreKit implements ICoreKit, IMPCContext {
}

const authSignatures = await this.getSessionSignatures();
await this.tKey.deleteFactorPub({ factorKey: this.state.factorKey, deleteFactorPub: factorPub, authSignatures, tssTag: TSS_TAG_DEFAULT });
await this.tKey.deleteFactorPub({ factorKey: this.state.factorKey, deleteFactorPub: factorPub, authSignatures });
const factorPubHex = fpp.toSEC1(factorKeyCurve, true).toString("hex");
const allDesc = this.tkey.metadata.getShareDescription();
const keyDesc = allDesc[factorPubHex];
Expand Down Expand Up @@ -1097,7 +1096,6 @@ export class Web3AuthMPCCoreKit implements ICoreKit, IMPCContext {
factorKey: this.state.factorKey,
authSignatures: this.state.signatures,
keyType,
tssTag: TSS_TAG_DEFAULT,
});

const accountNonce = this.getAccountNonce();
Expand All @@ -1124,7 +1122,6 @@ export class Web3AuthMPCCoreKit implements ICoreKit, IMPCContext {
const exportEd25519Seed = await this.tKey._UNSAFE_exportTssEd25519Seed({
factorKey: this.state.factorKey,
authSignatures: this.state.signatures,
tssTag: TSS_TAG_DEFAULT,
});

return exportEd25519Seed;
Expand Down Expand Up @@ -1538,7 +1535,6 @@ export class Web3AuthMPCCoreKit implements ICoreKit, IMPCContext {
newFactorPub,
newTSSIndex: newFactorTSSIndex,
refreshShares: this.state.tssShareIndex !== newFactorTSSIndex, // Refresh shares if we have a new factor key index.
tssTag: TSS_TAG_DEFAULT,
});
}

Expand Down
Loading