Fix/disableHashedFactorkey #223
Open
+478
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/mpcCoreKit.ts
Outdated
Comment on lines
901
to
912
| if (this.sessionId) { | ||
| const payload: SessionData = { | ||
| postBoxKey: this.state.postBoxKey, | ||
| postboxKeyNodeIndexes: this.state.postboxKeyNodeIndexes || [], | ||
| factorKey: this.state.factorKey?.toString("hex"), | ||
| tssShareIndex: this.state.tssShareIndex as number, | ||
| tssPubKey: this.state.tssPubKey?.toString("hex"), | ||
| signatures: this.signatures, | ||
| userInfo: this.state.userInfo, | ||
| }; | ||
| this.sessionManager.updateSession(payload); | ||
| } |
There was a problem hiding this comment.
@arch1995 should double check this. I'm not familiar with sessionManager.
| shareDescription: FactorKeyTypeShareDescription.Other, | ||
| updateMetadata: false, | ||
| }); | ||
| await this.setDeviceFactor(factorKey); |
There was a problem hiding this comment.
So this means the factor key was previously not persisted here, which is kind of catastrophic. We should have a test that asserts this.
| ]; | ||
|
|
||
| const email = "testmail99"; | ||
| const email = "testmail99-1"; |
There was a problem hiding this comment.
Why that change? (We briefly talked about it in our call, but I think it would be good to document it here.)
Comment on lines
+33
to
+36
| await coreKitInstance.tKey.storageLayer.setMetadata({ | ||
| privKey: new BN(coreKitInstance.state.postBoxKey!, "hex"), | ||
| input: { message: "KEY_NOT_FOUND" }, | ||
| }); |
There was a problem hiding this comment.
Why we no longer delete key on setup?
|
|
||
| const { idToken, parsedToken } = login ? await login(email) : await mockLogin(email); | ||
| await instance.init(); | ||
| await instance.init({ handleRedirectResult: false, rehydrate: false }); |
There was a problem hiding this comment.
What are the default values for these parameters? Did we change these? If so, why? Or are we just being more explicit here?
arch1995
approved these changes
Oct 23, 2025
arch1995
reviewed
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link:
Description
Fix feature disableHashedFactorkey
device factorkey is not set when disableHashedFactoryKey flag is set.
this is causing user lose the device factorkey during signup.
update session on commit
Session data is not updated when commits happens,
If user close and reopen the app this will cause user rehydrate( if rehydration is enabled) with old factorkey / metadata. This is causing the instance not consistent
update tests
update tests cases
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: