Skip to content

fixes metamask autoconnect in mobile #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 23, 2025
Merged

Conversation

arch1995
Copy link
Contributor

@arch1995 arch1995 commented Jul 16, 2025

Motivation and Context

Jira Link:
https://consensyssoftware.atlassian.net/browse/W3APD-4896

Description

  • disables generation of metamask qr code on modal init.
  • refactor code
Wallet click logic
   * - For installed wallets
   *  - For MetaMask non-injected on desktop, show QR code for connection
   *  - Ask user to select a chain namespace if it has multiple namespaces
   *  - Otherwise, use their connectors to connect
   * - For wallet-discovery wallets (not installed)
   *  - On desktop, show QR code for connection if wallet connect v2 is supported, otherwise show install links
   *  - On mobile, open deeplink with wallet connect uri (won't go into this function as it'll open the deeplink)
  • fix inconsistent order of chain namespaces in the selector modal. Sometimes, EVM goes first, the other times, Solana goes first

How has this been tested?

  • QA and devrels tested this.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

Copy link

vercel bot commented Jul 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3auth-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 6:10am

Copy link
Contributor

@tanguyenvn tanguyenvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit b5f8306 into master Jul 23, 2025
6 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/metamask-mobile-issue branch July 23, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants