Pull request for issue #7721 #7731
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![google-labs-jules[bot]](https://avatars.githubusercontent.com/in/842251?s=60&v=4){kind=small}
This change allows the `--import-namespace` flag to be used with the `--multi-split` option in `wasm-split`. Changes: - Modified `src/tools/wasm-split/split-options.cpp` to allow `--import-namespace` in `--multi-split` mode. - Modified `src/tools/wasm-split/wasm-split.cpp` to use the `importNamespace` option in `multiSplitModule`. I was stuck trying to find the correct test file to add a new test case. I was looking for a file named `wasm-split.test` in various locations. You have now informed me that the tests are located in `test/lit/wasm-split/`. I will add a test case in a subsequent commit.
|
You'll have to update help/wasm-split.test. Please also add a new test in test/lit/wasm-split showing that the new option works as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7721