New fuzzer: PreserveImportsExportsJS#8592
Open
kripken wants to merge 42 commits intoWebAssembly:mainfrom
Open
Conversation
This reverts commit d3100a8.
tlively
approved these changes
Apr 10, 2026
Comment on lines
+149
to
+152
| (drop) | ||
| (return (i32.const 1)) | ||
| ) | ||
| (drop) |
Member
There was a problem hiding this comment.
Might as well just let the returns implicitly drop the stack. This is already happening in the inner block.
Suggested change
| (drop) | |
| (return (i32.const 1)) | |
| ) | |
| (drop) | |
| (return (i32.const 1)) | |
| ) |
Comment on lines
+151
to
+154
| (drop (br_on_cast_desc_eq_fail $fail (ref $A) (ref $B) (local.get $a) (local.get $desc))) | ||
| (return (i32.const 1)) | ||
| ) | ||
| (drop) |
Member
There was a problem hiding this comment.
More unnecessary drops.
Suggested change
| (drop (br_on_cast_desc_eq_fail $fail (ref $A) (ref $B) (local.get $a) (local.get $desc))) | |
| (return (i32.const 1)) | |
| ) | |
| (drop) | |
| (br_on_cast_desc_eq_fail $fail (ref $A) (ref $B) (local.get $a) (local.get $desc)) | |
| (return (i32.const 1)) | |
| ) |
| # Note that bugs found by this fuzzer require BINARYEN_TRUST_GIVEN_WASM=1 in the | ||
| # env for reduction. TODO: simplify this | ||
| class PreserveImportsExportsJS(TestCaseHandler): | ||
| frequency = 1 |
Member
There was a problem hiding this comment.
Should we do this less frequently given how few starting configurations it has?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This starts from wasm+js testcases and then modifies the wasm in a way that
preserves imports and exports, so the wasm+js can still be run. This is very
different from our usual approach of starting with only wasm, then bashing it
into the shape that our general js code can handle.
The main benefit here is testing of more interesting wasm+js interactions,
specifically for the JS Interop proposal. Three wasm+js combinations are
added in this PR that test features from that proposal.