Allow struct.wait on equality-comparable fields except floats - #8939
Open
stevenfontanella wants to merge 3 commits into
Open
Allow struct.wait on equality-comparable fields except floats#8939stevenfontanella wants to merge 3 commits into
stevenfontanella wants to merge 3 commits into
Conversation
stevenfontanella
force-pushed
the
waitqueue-eq
branch
2 times, most recently
from
July 28, 2026 20:26
12a3523 to
ff41b36
Compare
stevenfontanella
force-pushed
the
waitqueue-eq
branch
from
August 11, 2026 22:10
5a4d346 to
01fd17a
Compare
stevenfontanella
changed the title
stevenfontanella
force-pushed
the
waitqueue-eq
branch
4 times, most recently
from
August 14, 2026 18:46
1333839 to
bc727ff
Compare
stevenfontanella
force-pushed
the
waitqueue-eq
branch
from
August 14, 2026 19:20
bc727ff to
41cfd56
Compare
stevenfontanella
marked this pull request as ready for review
August 14, 2026 20:06
kripken
reviewed
Aug 14, 2026
| ht = curr->ref->type.getHeapType(); | ||
| } | ||
| const auto& fields = ht->getStruct().fields; | ||
| if (curr->index >= fields.size()) { |
Member
Author
There was a problem hiding this comment.
I think this could happen if we create an out-of-bounds index using the C/JS API, and then the user code never validates the module. Otherwise the parser will already catch this:
binaryen/src/parser/contexts.h
Line 1802 in 8d9412e
fields below on line 1049. Does it make sense? I'm a little confused on what ChildTyper does, even after chatting with Gemini. I see that it's generating 'constraints' on children, but it's not checking the full set of required types because validation will do that in general.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8315. #8672 added struct.wait for i32 struct fields, but left out support for i64 and subtypes of
ref null (shared eq). See the details in the proposal.