Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

[js-api] Throw consistent exns in "read the imports" #523

Merged
merged 4 commits into from
Feb 16, 2024
Merged

[js-api] Throw consistent exns in "read the imports" #523

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9302a8
[spec] Throw consistent exns in "read the imports"
takikawa Feb 15, 2024
e1b39d5
[js-api] Throw consistent exns in "read the imports"
takikawa Feb 15, 2024
cae2341
Catch only TypeError in case TWAV throws other exns in the future
takikawa Feb 15, 2024
094a902
Merge branch 'link-error' of github.com:takikawa/gc into link-error
takikawa Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion document/js-api/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ A {{Module}} object represents a single WebAssembly module. Each {{Module}} obje
1. Throw a {{LinkError}} exception.
1. If |valtype| is [=v128=],
1. Throw a {{LinkError}} exception.
1. Let |value| be [=ToWebAssemblyValue=](|v|, |valtype|).
1. Let |value| be [=ToWebAssemblyValue=](|v|, |valtype|). If this operation throws an exception, catch it, and throw a {{LinkError}} exception.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should be specific to TypeError here. If there is any chance that TWAV could throw another exception (now or in the future), should that also become a LinkError? (Probably not.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could make sense to be specific to TypeError, so I pushed that change. I think in practice it shouldn't be possible for TWAV to throw other exceptions at this particular call site currently.

For example, TWAV can throw a SyntaxError if BigInt conversion fails on a string but it should be guarded by the conditions here. But that property isn't immediately apparent either.

1. Let |store| be the [=surrounding agent=]'s [=associated store=].
1. Let (|store|, |globaladdr|) be [=global_alloc=](|store|, [=const=] |valtype|, |value|).
1. Set the [=surrounding agent=]'s [=associated store=] to |store|.
Expand Down