-
Couldn't load subscription status.
- Fork 17
Reduce Kotlin-compose-wasm iteration count #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Kotlin-compose-wasm is the longest running test in JS3 by a pretty wide margin. However after the first few iterations almost all code is in the most optimizing compiler in the respective engines. This change reduces the iterations to 5 and sets adjusts the worst case count accordingly.
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
CC @eqrion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me. I also briefly checked that the scores on x64 with all three shells are roughly the same. I am however a bit worried about noise/flaky results with worstCaseCount: 1, how about compromising on 10 iterations with 2 worst case?
| "./simple/doxbee-promise.js", | ||
| ], | ||
| tags: ["default", "js", "promise", "Simple"], | ||
| iterations: 80, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the doxbee changes intended (or accidental)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, accidental, will revert.
That would make it still quite long (~4 sec) on my M2 MBP (probably a lot worse on phones/older CPUs). Let me run a variance analysis on the worst case count for this benchmark and get back to you. It seems somewhat unlikely it's dramatically worse than |
|
Some numbers: |
|
We can discuss offline but those numbers don't seem too bad relative to other |
Kotlin-compose-wasm is the longest running test in JS3 by a pretty wide margin. However after the first few iterations almost all code is in the most optimizing compiler in the respective engines.
This change reduces the iterations to 5 and sets adjusts the worst case count accordingly.