PHP 8.5 | Fix various "Using null as an array offset" deprecation notices #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tices Fixes deprecation notices which occur if `$this->scheme` is `null`. Fixed now via some extra defensive coding. This change is already covered via the existing tests. Ref: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_using_values_null_as_an_array_offset_and_when_calling_array_key_exists
…recation notice Fixes deprecation notices which occur if `$offset` is `null`. Fixed now via some extra defensive coding. This change is already covered via the existing tests. Ref: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_using_values_null_as_an_array_offset_and_when_calling_array_key_exists
…g null as an array offset" deprecation notices Fixes deprecation notices which occur if `$offset` is `null`. Fixed now via some extra defensive coding. This change is already covered via the existing tests. Ref: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_using_values_null_as_an_array_offset_and_when_calling_array_key_exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Description
PHP 8.5 | Iri: fix two "Using null as an array offset" deprecation notices
Fixes deprecation notices which occur if
$this->schemeisnull.Fixed now via some extra defensive coding.
This change is already covered via the existing tests.
Ref: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_using_values_null_as_an_array_offset_and_when_calling_array_key_exists
PHP 8.5 | Response/Headers: fix a "Using null as an array offset" deprecation notice
Fixes deprecation notices which occur if
$offsetisnull.Fixed now via some extra defensive coding.
This change is already covered via the existing tests.
Ref: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_using_values_null_as_an_array_offset_and_when_calling_array_key_exists
PHP 8.5 | Utility/CaseInsensitiveDictionary: fix another set of "Using null as an array offset" deprecation notices
Fixes deprecation notices which occur if
$offsetisnull.Fixed now via some extra defensive coding.
This change is already covered via the existing tests.
Ref: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_using_values_null_as_an_array_offset_and_when_calling_array_key_exists