Block editor: migrate block-card Badge to UI Badge - #82503
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 PR meta 🤖📦 Bundle sizeSize Change: +75 B (0%) Total Size: 8 MB 📦 View Changed
⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
🏁 Flaky testsShow the failuresSome tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information. uses the anchor chosen for a heading after publish in
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
|
@mirka There wasn't a strong semantic reason for the difference. Here I used I'll align this with #82500 and switch to the default none intent. Regarding overflow scenarios: Tested this with a long custom block name in a narrow sidebar and its working fine. the current badge text is truncated with an ellipsis due to Do we need to change this behavior as well? Ref: |
|
I just dropped a comment in #82500 suggesting using a badge with higher intent. Regarding the semantics of this use case and its intent, I will use |
Did you find situations in the previous implementation where the block name badge was actually ellipsized, and not ellipsizing here would cause issues? |
+1 to this |


Part of #82440
What?
Migrate the block-type badge in
BlockCardfrom the private@wordpress/componentsBadgeto the public@wordpress/uiBadge.Why?
We're deprecating wp-components Badge and migrating to UI Badge.
How?
Simple component switch. Uses
intent="draft"to keep a neutral look close to the previous badge.Testing Instructions
Intro Line.Screenshots or screencast
Use of AI Tools