Workflow: Replace cmdk with the @wordpress/ui Autocomplete primitive - #82504
Workflow: Replace cmdk with the @wordpress/ui Autocomplete primitive#82504t-hamano wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🤖 PR meta 🤖📦 Bundle sizeSize Change: +63.2 kB (+0.79%) Total Size: 8.07 MB 📦 View Changed
⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
|
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
bc2c152 to
8f40861
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| value={ ability.label } | ||
| <Autocomplete.Root | ||
| items={ items } | ||
| mode="none" |
There was a problem hiding this comment.
Since the options are filtered from the typed text, mode="none" makes the input expose the wrong aria-autocomplete value.
Should we keep the external filtering but use list autocomplete semantics? Potentially with filteredItems? So that screen readers are told that matching suggestions are available
Part of #76950
What?
Rebuilds the experimental workflow palette on top of the
Autocompleteprimitive from@wordpress/ui, replacingcmdk.Why?
Both the command palette and the workflow palette are built on cmdk. The library has unresolved accessibility issues, and its repository has seen almost no activity.
Autocompleteshould be able to cover the same ground, and doing so should resolve those issues.How?
The command palette also owns dynamic command loaders and recently used commands, which makes it a larger change. The workflow palette is far simpler, so it goes first.
Testing Instructions
Enable the Workflow Palette experiment, and open the browser console and run the following to register test abilities:
Test abilities
Testing Instructions for Keyboard
Test ability, 1 of 20.Bulk ability 001, 1 of 10.Screenshots or screencast
Use of AI Tools
The refactor and the test snippet above were written with Claude Code (Opus). The result has been reviewed and manually tested, including with a screen reader.