Open
Conversation
1. Use deferred BEGIN (SHARED lock) instead of BEGIN IMMEDIATE (RESERVED lock) for read-only wrapper transactions (SHOW, DESCRIBE). 2. Skip the wrapper transaction entirely for SELECT statements. Fixes: #318
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces lock contention under concurrent access by avoiding unnecessary write locks for read-only queries.
BEGIN/COMMITneeded.BEGINfor other read-only wrapper transactions. SHOW and DESCRIBE queries still use a wrapper transaction (they may translate to multiple SQLite queries), but now use a deferredBEGIN(SHARED lock) instead ofBEGIN IMMEDIATE(RESERVED lock).Background
The wrapper transaction previously used
BEGIN IMMEDIATEfor all queries, including read-only SELECTs. This acquired a RESERVED (write) lock on every query — but SQLite only allows one RESERVED lock at a time. Under concurrent load (e.g., multiple PHP-FPM workers handling requests simultaneously), all processes competed for the single write lock. When the 10-second busy timeout was exceeded, SQLite returnedSQLITE_BUSY("database is locked", error 5).SHARED locks, acquired by a deferred
BEGIN, are compatible with RESERVED locks — multiple readers can proceed concurrently alongside an active writer.Fixes #318