Skip to content

Conversation

@mcguffin
Copy link

@mcguffin mcguffin commented Nov 6, 2022

This is a proof of concept and a follow-up for #427.

The transformation is happening in includes/WebAuthn/class-webauthn-key-migrator.php. The PHP is mainly gathered together from sjinks/wp-two-factor-provider-webauthn and madwizard-org/webauthn-server.

Apart from reviewing, here's what I think should be the next steps:

  • Key migration is currently triggered by the user in the U2F keys admin table. However we could do it automatically, eg. when the user is visiting his/her profile page, like sjinks/wp-two-factor-provider-webauthn does. I'm feeling indecisive about it and I'm looking forward for your feedback and opinions.
  • Add an admin message after a key has been migrated.
  • Real life testing with actual U2F / YubiKeys
  • Unit tests

@burnedfaceless
Copy link

@dd32 Can you please merge this pull request for me? I would really like to be able to use my U2F Keys again.

@dd32
Copy link
Member

dd32 commented Feb 6, 2023

dd32 Can you please merge this pull request for me?

This isn't my call. I would suggest using a plugin that adds a WebAuthN provider in the meantime: https://wordpress.org/plugins/two-factor-provider-webauthn/
(edit: Worth mentioning; I haven't reviewed that plugin, I know others who use it, I don't know if the future built-in Two Factor WebAuthN support will support it or migrate those registered keys)

@jeffpaul jeffpaul modified the milestones: 0.9.0, 0.10.0 May 8, 2024
@jeffpaul jeffpaul modified the milestones: 0.14.0, 0.15.0 Jul 3, 2025
@adampl
Copy link

adampl commented Oct 14, 2025

are you serious? waiting 2.5+ years for review? :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants