Skip to content

Conversation

dmsnell
Copy link
Member

@dmsnell dmsnell commented Oct 11, 2025

Trac ticket: Core-63694.
See WordPress/gutenberg#72264.

For classic themes, image blocks need to create a DIV wrapper which contains alignment classes from the inner FIGURE. This has been processed using PCRE matching.

With this change the HTML API is used instead of PCRE functions to provide more semantic transformation, clearer intent, and eliminate possible parsing issues.

Trac ticket: Core-63694.
See WordPress/gutenberg#72264.

For classic themes, image blocks need to create a DIV wrapper which
contains alignment classes from the inner FIGURE. This has been
processed using PCRE matching.

With this change the HTML API is used instead of PCRE functions to
provide more semantic transformation, clearer intent, and eliminate
possible parsing issues.
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dmsnell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

dmsnell added a commit to WordPress/gutenberg that referenced this pull request Oct 16, 2025
For classic themes, image blocks need to create a `DIV` wrapper which
contains alignment classes from the inner `FIGURE`. This has been
processed using PCRE matching.

With this change the HTML API is used instead of PCRE functions to
provide more semantic transformation, clearer intent, and eliminate
possible parsing issues.

Co-authored-by: Glen Davies <[email protected]>
Co-authored-by: tellthemachines <[email protected]>
Github-PR: 72264
Github-PR-URL: #72264
Core-Backport-PR: WordPress/wordpress-develop#10218
Core-Backport-PR-URL: WordPress/wordpress-develop#10218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant