Add Theme File Editor notice when editing a stylesheet for a block theme and warn when there is a minified version available #10279

westonruter · 2025-10-15T05:57:09Z

This is a follow-up to #10081 (r60934 and b56b386) based on a discussion with @peterwilsoncc. A CSS comment was added to the style.css for TT2 and TT5 to warn against editing since the style.min.css will likely be served instead:

/*
 * IMPORTANT: This file is only served on the frontend when `SCRIPT_DEBUG` is enabled;
 * in most instances, the `style.min.css` file will be served. It is not recommended that you
 * use the Theme File Editor to modify this stylesheet. Instead, add the necessary style
 * overrides via "Additional CSS" in the Site Editor.
 */

However, the user may not see this easily. Therefore, this PR adds an admin notice when editing a CSS file when there is also a .min.css version for that same file name in the current theme.

Additionally, for non-block themes there was an admin info notice about using the Custom CSS in the Customizer to edit CSS, but there was no corresponding notice to prompt users to use Additional CSS in the Site Editor for block themes. So this rectifies that issue. The new notices appear as follows when editing style.css in TT5:

Trac ticket: https://core.trac.wordpress.org/ticket/63012

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…k theme

github-actions · 2025-10-15T06:53:05Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props westonruter, jorbin, peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

src/wp-admin/theme-editor.php

Co-authored-by: Aaron Jorbin <[email protected]>

aaronjorbin · 2025-10-15T14:34:42Z

src/wp-admin/theme-editor.php

+		);
+	}
+	if ( file_exists( preg_replace( '/\.css$/', '.min.css', $file ) ) ) {
+		$message = '<p><strong>' . __( 'There is a minified version of this stylesheet.' ) . '</strong></p><p>' . sprintf(


The sprintf can also be eliminated since there is no substitution (sorry, didn't catch that earlier)

The apologies should be mine!

Removed in 9383f2e

Co-authored-by: Aaron Jorbin <[email protected]>

peterwilsoncc

This looks good, thanks.

A couple of notes inline: I think it's best practice if translator comments are uniform for repeated strings. WP CLI throws a warning if they differ. Someone on the polyglots team will be able to confirm.

I've suggested an ID for the new warning message, feel free to come up with a better name.

src/wp-admin/theme-editor.php

Co-authored-by: Peter Wilson <[email protected]>

peterwilsoncc

This looks good to me and tests well.

Testing notes:

2025: Link goes to site editor
2025: Warning shown when editing stylesheet
2014: Link goes to customizer
2014: touch src/wp-content/themes/twentyfourteen/style.min.css causes the warning to be shown.
2014: Without the fake file, the warning is not shown.

westonruter · 2025-10-16T00:12:20Z

FYI: In the SVN commit, I'm improving the construction of the Site Editor URL as follows:

--- a/src/wp-admin/theme-editor.php
+++ b/src/wp-admin/theme-editor.php
@@ -227,10 +227,22 @@ if ( preg_match( '/\.css$/', $file ) ) {
 			)
 		);
 	} elseif ( wp_is_block_theme() && current_user_can( 'edit_theme_options' ) ) {
+		$site_editor_url = admin_url(
+			add_query_arg(
+				urlencode_deep(
+					array(
+						'p'       => '/styles',
+						'section' => '/css',
+					)
+				),
+				'site-editor.php'
+			)
+		);
+
 		$message = '<p><strong>' . __( 'Did you know?' ) . '</strong></p><p>' . sprintf(
 			/* translators: %s: Link to add custom CSS section in either the Customizer (classic themes) or Site Editor (block themes). */
 			__( 'There is no need to change your CSS here &mdash; you can edit and live preview CSS changes in the <a href="%s">built-in CSS editor</a>.' ),
-			esc_url( admin_url( 'site-editor.php?p=%2Fstyles&section=%2Fcss' ) )
+			esc_url( $site_editor_url )
 		) . '</p>';
 		wp_admin_notice(
 			$message,

* When a block theme is active, add a notice to advise using Additional CSS in the Site Editor. A similar notice is already directing users to Custom CSS in the Customizer when a classic theme is active. * When there is a minified file (`*.min.css`) present for the current CSS file, warn that any edits may not be served to visitors. Developed in #10279 Follow-up to [60934]. Props westonruter, peterwilsoncc, jorbin. See #63012. git-svn-id: https://develop.svn.wordpress.org/trunk@60943 602fd350-edb4-49c9-b593-d223f7449a82

westonruter · 2025-10-16T00:16:57Z

Committed in c978e55 (r60943).

* When a block theme is active, add a notice to advise using Additional CSS in the Site Editor. A similar notice is already directing users to Custom CSS in the Customizer when a classic theme is active. * When there is a minified file (`*.min.css`) present for the current CSS file, warn that any edits may not be served to visitors. Developed in WordPress/wordpress-develop#10279 Follow-up to [60934]. Props westonruter, peterwilsoncc, jorbin. See #63012. Built from https://develop.svn.wordpress.org/trunk@60943 git-svn-id: http://core.svn.wordpress.org/trunk@60279 1a063a9b-81f0-0310-95a4-ce76da25c4cd

* When a block theme is active, add a notice to advise using Additional CSS in the Site Editor. A similar notice is already directing users to Custom CSS in the Customizer when a classic theme is active. * When there is a minified file (`*.min.css`) present for the current CSS file, warn that any edits may not be served to visitors. Developed in WordPress/wordpress-develop#10279 Follow-up to [60934]. Props westonruter, peterwilsoncc, jorbin. See #63012. Built from https://develop.svn.wordpress.org/trunk@60943 git-svn-id: https://core.svn.wordpress.org/trunk@60279 1a063a9b-81f0-0310-95a4-ce76da25c4cd

mukeshpanchal27 · 2025-10-16T10:06:22Z

src/wp-admin/theme-editor.php

+			)
+		);
+	}
+	if ( file_exists( preg_replace( '/\.css$/', '.min.css', $file ) ) ) {


@westonruter In the development version, SCRIPT_DEBUG is set to true, so this notice does not makes sense since it loads CSS from the unminified .css file. However, in production, SCRIPT_DEBUG is false, meaning that CSS won’t be applied as it load .min.css file.

This creates a bit of a trade-off not sure if we actually need this notice in that case 🤔

I'm not sure I understand. The issue is that the changes to style.css may not be served to visitors, depending on whether SCRIPT_DEBUG is enabled. If someone temporarily enables script debug, then they would confused why their fix no longer appears after changing the file and turning script debug off. So the warning seems important.

Got it. Thanks for clarification.

westonruter added 2 commits October 14, 2025 22:50

Add notice to use Additional CSS in the Site Editor when using a bloc…

3f6dc40

…k theme

Add warning about editing a stylesheet when there is a minified version

ed037a0

westonruter requested review from carolinan and peterwilsoncc October 15, 2025 05:57

westonruter mentioned this pull request Oct 15, 2025

Add stylesheet minification for bundled themes (Block themes) #10081

Closed

6 tasks

aaronjorbin reviewed Oct 15, 2025

View reviewed changes

src/wp-admin/theme-editor.php Outdated Show resolved Hide resolved

Remove unneeded translators comment

bd06646

Co-authored-by: Aaron Jorbin <[email protected]>

aaronjorbin reviewed Oct 15, 2025

View reviewed changes

Remove extraneous sprintf()

9383f2e

Co-authored-by: Aaron Jorbin <[email protected]>

peterwilsoncc reviewed Oct 15, 2025

View reviewed changes

src/wp-admin/theme-editor.php Show resolved Hide resolved

src/wp-admin/theme-editor.php Outdated Show resolved Hide resolved

src/wp-admin/theme-editor.php Outdated Show resolved Hide resolved

westonruter and others added 3 commits October 15, 2025 15:26

Add ID attribute

36d9fc0

Co-authored-by: Peter Wilson <[email protected]>

Use uniform translator comments for repeated strings

449b912

Co-authored-by: Peter Wilson <[email protected]>

Use uniform translator comments for repeated strings

7058ee6

Co-authored-by: Peter Wilson <[email protected]>

westonruter requested a review from peterwilsoncc October 15, 2025 22:28

peterwilsoncc approved these changes Oct 15, 2025

View reviewed changes

westonruter closed this Oct 16, 2025

mukeshpanchal27 reviewed Oct 16, 2025

View reviewed changes

Add Theme File Editor notice when editing a stylesheet for a block theme and warn when there is a minified version available #10279

Add Theme File Editor notice when editing a stylesheet for a block theme and warn when there is a minified version available #10279

Conversation

westonruter commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

aaronjorbin Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

westonruter Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

westonruter Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

peterwilsoncc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

peterwilsoncc left a comment

Choose a reason for hiding this comment

Uh oh!

westonruter commented Oct 16, 2025

Uh oh!

westonruter commented Oct 16, 2025

Uh oh!

mukeshpanchal27 Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

westonruter Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

mukeshpanchal27 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Oct 15, 2025 •

edited

Loading