Skip to content

#63170 Unify the notation used for version ranges #9424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/coding-standards.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ on:
- '3.[89]'
- '[4-9].[0-9]'
tags:
- '[0-9]+.[0-9]'
- '[0-9]+.[0-9].[0-9]+'
- '!3.7.[0-9]+'
- '3.[89]'
- '3.[89].[0-9]+'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since none of the 3.x versions supported versions, do they even need to have the workflow as a trigger?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the retired branches were left in the past to avoid any possible headaches when backporting changes to older branches. But now that all workflows running in older branches make use of the reusable pattern, there are almost no changes to the calling workflow files required.

The only other reason to leave is a way to document branches that used the workflow. But most have an inline comment documenting that above the events.

- '[4-9].[0-9]'
- '[4-9].[0-9].[0-9]+'
pull_request:
branches:
- trunk
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/end-to-end-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ on:
- '5.[3-9]'
- '[6-9].[0-9]'
tags:
- '[0-9]+.[0-9]'
- '[0-9]+.[0-9].[0-9]+'
- '![34].[0-9].[0-9]+'
- '!5.[0-2].[0-9]+'
- '5.[3-9]'
- '5.[3-9].[0-9]+'
- '[6-9]+.[0-9]'
- '[6-9]+.[0-9].[0-9]+'
pull_request:
branches:
- trunk
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/javascript-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@ on:
- '3.[89]'
- '[4-9].[0-9]'
tags:
- '[0-9]+.[0-9]'
- '[0-9]+.[0-9].[0-9]+'
- '!3.7.[0-9]+'
- '3.[89]'
- '3.[89].[0-9]+'
- '[4-9].[0-9]'
- '[4-9].[0-9].[0-9]+'
pull_request:
branches:
- trunk
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/local-docker-environment.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Local Docker Environment

on:
# Local Docker environment testing was introduced in WordPress 6.8.
push:
branches:
- trunk
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/performance.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
name: Performance Tests

on:
# Performance testing was introduced in WordPress 6.2.
push:
branches:
- trunk
- '6.[2-9]'
- '[7-9].[0-9]'
tags:
- '[0-9]+.[0-9]'
- '[0-9]+.[0-9].[0-9]+'
- '![45].[0-9].[0-9]+'
- '!6.[01].[0-9]+'
- '6.[2-9]'
- '6.[2-9].[0-9]+'
- '[7-9].[0-9]'
- '[7-9].[0-9].[0-9]+'
pull_request:
branches:
- trunk
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/php-compatibility.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ on:
- '5.[5-9]'
- '[6-9].[0-9]'
tags:
- '[0-9]+.[0-9]'
- '[0-9]+.[0-9].[0-9]+'
- '![34].[0-9].[0-9]+'
- '!5.[0-4].[0-9]+'
- '5.[5-9]'
- '5.[5-9].[0-9]+'
- '[6-9].[0-9]'
- '[6-9].[0-9].[0-9]+'
pull_request:
branches:
- trunk
Expand Down
Loading