Skip to content

Remove support for IE conditional scripts and styles #9497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

joedolson
Copy link
Contributor

Returns false if conditional scripts or styles are identified; updates comments; removes files that were only loaded conditionally.

Trac ticket: https://core.trac.wordpress.org/ticket/63821


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Returns false if conditional scripts or styles are identified; updates comments; removes files that were only loaded conditionally.
Copy link

github-actions bot commented Aug 15, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joedolson, jonsurrell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sirreal
Copy link
Member

sirreal commented Aug 16, 2025

I scanned this and didn't t see any _doing_it_wrong_ or similar notices in this change. Did you add any? Should some notice be included?

What if each class handed some notice and ignored conditionals in ::add_data()? They could avoiding adding conditional scripts/styles at all. It would save handling conditional scripts and styles when printing.

We could consider doing that in WP_Dependencies::add_data() as well, although there's a small risk of affecting other subclasses. I scanned a quick wpdirectory search and it didn't seem likely to be a problem, but it would be safer to do it in the script and style classes.

@joedolson
Copy link
Contributor Author

I was thinking about handling this in ::add_data(), but if we exit before adding the data, then the related script will still be handled, and will be printed to the page, just without conditionals. Handling it in do_item() allows us to also ignore the script itself and its dependencies.

I guess we could de-register the handle in add_data(), but that feels dirty, somehow.

Can still handle a deprecation notice in add_data(), though.

Prevent dependencies from being added when only required by a conditional script or style.
@sirreal sirreal self-requested a review August 19, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants