-
Notifications
You must be signed in to change notification settings - Fork 3k
Remove support for IE conditional scripts and styles #9497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Returns false if conditional scripts or styles are identified; updates comments; removes files that were only loaded conditionally.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
I scanned this and didn't t see any What if each class handed some notice and ignored conditionals in We could consider doing that in |
I was thinking about handling this in I guess we could de-register the handle in Can still handle a deprecation notice in |
Prevent dependencies from being added when only required by a conditional script or style.
Returns false if conditional scripts or styles are identified; updates comments; removes files that were only loaded conditionally.
Trac ticket: https://core.trac.wordpress.org/ticket/63821
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.