[PHP.wasm] Support non-blocking read streams #2328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Enhancement
adamziel
commented
Jul 5, 2025
| @@ -344,6 +344,8 @@ EM_JS(__wasi_errno_t, js_fd_read, (__wasi_fd_t fd, const __wasi_iovec_t *iov, si | |||
| } | |||
|
|
|||
| const success = returnCode === 0; | |||
| // @TODO: Do not reason about child_proc_by_fd. Just use pipes and detect | |||
There was a problem hiding this comment.
Actually, PHP uses that distinction internally, so maybe it's not a problem at all? Although we operate at the kernel level here.
if (data->is_process_pipe) {
errno = 0;
ret = pclose(data->file);
#if HAVE_SYS_WAIT_H
if (WIFEXITED(ret)) {
ret = WEXITSTATUS(ret);
}
#endif
} else {
ret = fclose(data->file);
data->file = NULL;
}
|
superseded by #2339 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Description TBD.
With this PR, we can use the Symfony
Processcomponent. It spawns a new process viaproc_open(), marks its output stream as non-blocking, and immediately reads the initial output bytes if any are present. Before this change, Playground would block until the first output is produced, and, sometimes until the entire process finishes.Implementation details
Testing Instructions (or ideally a Blueprint)