[PHP] Isomorphic, reusable spawn handler #2359
Merged
+104
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts sandboxedSpawnHandlerFactory() as a separate export from `@php-wasm/universal`. Every module can reuse it now instead of recreating new spawn handlers. ## Testing instructions Confirm the CI tests pass
adamziel
added
[Type] Enhancement
adamziel
force-pushed
the
extract-spawn-handler
branch
from
cef314d to
409d114
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts
sandboxedSpawnHandlerFactory()as a separate export from@php-wasm/universal. Every module can reuse it now instead of recreating new spawn handlers.Pre-requisite for #2281
Testing instructions
Confirm the CI tests pass