[Remote] Use CORS proxy in embedded Playgrounds #2369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Playground does not use the CORS proxy when its embedded on another site via an iframe. This PR changes that and defaults to using CORS proxy also in embeds. ## Testing instructions TBD
adamziel
added
[Type] Enhancement
adamziel
changed the title
|
This seems like a good move. If the remote embeds CORS proxy support, does that mean the website and builder can stop passing a corsProxyUrl and get that for free? |
Good spot! Yes, I'll update the PR to remove the explicit corsProxyUrl from those places. |
|
There is a built-npm-packages test failure for PHP 7.2 and the ES module test there, but it occurred before this PR. Let's merge this and then look at that failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playground does not use the CORS proxy when its embedded on another site via an iframe. This PR changes that and defaults to using CORS proxy also in embeds.
Follows-up on #2368
Testing instructions