[Node] Gracefully handle connection errors in the outbound network proxy #2370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
adamziel
deleted the
networking-proxy-error-handling-concurrent-connections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
As discovered in Automattic/studio#1491, adding a timeout before closing the network connection in the outbound network proxy prevents freezing the PHP runtime when the target cannot be reached.
This PR adds such a timeout.
The exact reason behind this behavior isn't well understood yet. The freeze is not deterministic or easy to reproduce, which is why this PR does not ship any tests. We should keep an eye on this and, if it ever comes up again, invest some time in a proper deep dive to understand all the factors at play.
Related to Automattic/studio#1491
cc @gavande1 @mho22