[Boot] Verify permalink structure is actually set #2902
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stallation The previous implementation of installWordPress() relied on `update_option`'s return value to determine if pretty permalinks were successfully enabled. However, `update_option` returns false when the value hasn't changed, e.g. when it already was set to what we need. This led to incorrect detection. This change explicitly verifies the permalink structure was set by reading it back with `get_option` and comparing it to the expected value. This ensures we accurately detect whether pretty permalinks are active, regardless of whether the option already existed or was newly created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of installWordPress() relied on
update_option's return value to determine if pretty permalinks were successfully enabled. However,update_optionreturns false when the value hasn't changed, e.g. when it already was set to what we need. This led to incorrect detection.This PR explicitly verifies the final
permalink_structurevalue instead of relying on implicitupdate_option()return.Testing Instructions (or ideally a Blueprint)
CI