Await php.ini writes during boot - #4265
Draft
mho22 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bootRequestHandler()calledsetPhpIniEntries()without awaiting it. That function awaitsphp.readFileAsText()before writing, so it returns at the await point and the write tophp.inilands in a later microtask.applyLegacyPhpIniOverrides()ran next and merged the legacy network-disable list into the same file. On legacy PHP it could readphp.inibefore thephpIniEntrieswrite had landed, and the late write then overwrotedisable_functions,allow_url_fopen, anddate.timezone.applyLegacyPhpIniOverrides()had the same defect internally: it calledsetPhpIniEntries()without awaiting and returnedvoid.What this changes
createPhp()inboot.tsawaits bothsetPhpIniEntries()andapplyLegacyPhpIniOverrides().applyLegacyPhpIniOverrides()becomesasync, returnsPromise<void>, and awaits its own write.This is not a breaking change.
applyLegacyPhpIniOverrides()is not re-exported from@wp-playground/wordpressandbootRequestHandler()is its only caller.Testing
npx nx test playground-wordpress— 136 passed.npx nx run playground-cli:test-playground-cli --testFiles=run-cli.spec.ts— 97 passed.