FED-3909 [hasDescription matcher] escape special characters in ids #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btr-rmconsole-1
bot
changed the title
greglittlefield-wf
requested changes
Jun 16, 2025
Contributor
greglittlefield-wf
left a comment
greglittlefield-wf
left a comment
There was a problem hiding this comment.
LGTM! Would you mind adding a 3.1.1 changelog.md entry that notes this fix, since this will get auto-released upon merge?
Contributor
Author
|
ope! Good call @greglittlefield-wf ! I might see if I can make a PR to add something in CI to remind us 🤷♀️ |
greglittlefield-wf
approved these changes
Jun 16, 2025
Contributor
greglittlefield-wf
left a comment
greglittlefield-wf
left a comment
There was a problem hiding this comment.
+10 @Workiva/release-management-p
btr-rmconsole-7
bot
added
RM Ready
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Failures in wdesk_sdk_extensibility revealed that our
hasDescriptionmatcher breaks with special characters in the id - this is the same problem as discovered in consumer testing (see doc).Changes
hasDescriptionuses in the querySelectorRelease Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: