-
Notifications
You must be signed in to change notification settings - Fork 166
Swapped to MySqlConnector instead of MySql.Data.MySqlClient #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…y faster at running queries than MySql.Data.MySqlClient.
|
This code conflicts with the previous pull request #124. Could you tell me which of the two codes is correct? I've tested them separately, but the error still persists when exporting to SQL. The table is created, but the records don't appear, and an error message is displayed. |
This is the only PR I made on this project. If you're wanting to merge in another PR on top of the base, you'd need to modify parts that are causing the conflict. I do not know if I tested exporting or not, this was to fix a connection issue, |
Thank you for your response. I'll see if the project is reactivated. If not, I'll try to find an alternative to reactivate it, even if it's in a different repository. If you're happy for that, when that happens, I'll ask you to look into the issue together and try to resolve the potential conflict it's causing. Ideally, it would work in both MySQL and MariaDB. Isn't that right? |
Hello, yes, with my PR it works with both MariaDB and MySQL. If you'd like, I'd be happy to cherry-pick the other PR into another repo. It looks like only a few minutes of work. I can look more into it tomorrow, though. |
Excellent, I'd be interested in having your code be part of the new repository, in case I can't contact the owner to reactivate it. However, the pull request prior to yours has a conflict when applying your changes, so we'd have to review it, or at least, I'd have you update the rest of the PRs, and then create a new PR with the updated changes. |
|
I only have 2 pull requests left to add, yours and the previous one. In the previous one, it is updated to .NET Framework 4.8, and although it is said that the errors when importing to SQL are corrected, the error still persists, because I tested it. However, you tell me that with this PR, it would be compatible not only for MySQL, but also for MariaDB, so I don't know what would be better to do, you tell me... https://github.com/pangolp/WDBXEditor |
|
Does it seem okay if we add the previous PR, and then review the changes you want to make, with the repository already updated? |
|
The repository is up to date; all that's left is to add your changes. If you could review it, I'd appreciate it. https://github.com/forumcorex/WDBXEditor |
Fixes support for MariaDB, and is generally faster at running queries than MySql.Data.MySqlClient anyway.
As of at least MariaDB 10.10.1 MySqlClient no longer works https://bugs.mysql.com/bug.php?id=109331.