-
-
Notifications
You must be signed in to change notification settings - Fork 454
Add Spanish translation file es_la.json #1131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request introduces a new JSON file ( Possibly related PRs
Suggested reviewers
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/main/resources/assets/wurst/translations/es_la.json (2)
51-51
: Potential Typo in 'allow_chorus':
The translation for "description.wurst.setting.autoeat.allow_chorus" reads:
"Comer fruta de corus te teletransporta a una ubicación aleatoria.\nNo recomendado."
It appears that "corus" might be a typo. Consider correcting it to "chorus" (or an appropriate Spanish equivalent) unless this is intentional.Suggested change:
-"description.wurst.setting.autoeat.allow_chorus": "Comer fruta de corus te teletransporta a una ubicación aleatoria.\nNo recomendado.", +"description.wurst.setting.autoeat.allow_chorus": "Comer fruta de chorus te teletransporta a una ubicación aleatoria.\nNo recomendado.",
1-308
: Optional: Maintainability Improvement:
For long translation files like this, consider reviewing if the keys should be sorted (or follow the same order as the default language file) to simplify future maintenance and cross-language comparisons. This is a non-critical, good-to-have enhancement.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/resources/assets/wurst/translations/es_la.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (4)
src/main/resources/assets/wurst/translations/es_la.json (4)
1-308
: Overall Structure and Formatting:
The JSON file is newly added and appears to be well structured and valid. All keys follow a clear naming convention and the string values—including the use of newline characters and color formatting codes—are consistently applied, which should ensure proper parsing and display by the application.
2-6
: Clear AimAssist Translations:
The translations for AimAssist (e.g. "description.wurst.hack.aimassist" and related settings) are concise and clearly communicate the intended functionality. They maintain the tone and technical accuracy needed for users.
7-16
: Consistent Airplace and AnchorAura Block:
The keys and values for Airplace (lines 7–9) and AnchorAura (lines 10–16) demonstrate a consistent tone and clarity. The explanations include helpful details and warnings (using newline breaks) that align well with similar entries in other language files.
17-23
: AntiAFK Translations Adequacy:
The AntiAFK-related entries (lines 17–23) are translated in a clear and informative manner. They properly explain both the functionality and the associated warnings (including the highlighted "ADVERTENCIA" with proper formatting).
This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks. Pull requests should be closed if:
|
🤙 |
Add Spanish translation file es_la.json for Wurst hacks and settings descriptions.