Skip to content

Add Spanish translation file es_la.json #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prahzera
Copy link

Add Spanish translation file es_la.json for Wurst hacks and settings descriptions.

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

coderabbitai bot commented Mar 17, 2025

Walkthrough

The pull request introduces a new JSON file (es_la.json) in the src/main/resources/assets/wurst/translations/ directory. This file provides Spanish translations for a variety of features and settings within the Wurst client, including hacks such as "aimassist," "autobuild," "killaura," and "speedhack," as well as settings options like filtering entities and adjusting attack speeds. The file follows standard JSON formatting, ensuring proper parsing by the application. The change involves the addition of key-value pairs for each feature or setting, including warnings and notes where relevant.

Possibly related PRs

  • Turkish language for wurst #1114: Introduced Turkish translations for similar features, implying a shared approach in handling language translations for the client.

Suggested reviewers

  • Alexander01998

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
src/main/resources/assets/wurst/translations/es_la.json (2)

51-51: Potential Typo in 'allow_chorus':
The translation for "description.wurst.setting.autoeat.allow_chorus" reads:
"Comer fruta de corus te teletransporta a una ubicación aleatoria.\nNo recomendado."
It appears that "corus" might be a typo. Consider correcting it to "chorus" (or an appropriate Spanish equivalent) unless this is intentional.

Suggested change:

-"description.wurst.setting.autoeat.allow_chorus": "Comer fruta de corus te teletransporta a una ubicación aleatoria.\nNo recomendado.",
+"description.wurst.setting.autoeat.allow_chorus": "Comer fruta de chorus te teletransporta a una ubicación aleatoria.\nNo recomendado.",

1-308: Optional: Maintainability Improvement:
For long translation files like this, consider reviewing if the keys should be sorted (or follow the same order as the default language file) to simplify future maintenance and cross-language comparisons. This is a non-critical, good-to-have enhancement.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cbeed5b and caa4bc8.

📒 Files selected for processing (1)
  • src/main/resources/assets/wurst/translations/es_la.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
🔇 Additional comments (4)
src/main/resources/assets/wurst/translations/es_la.json (4)

1-308: Overall Structure and Formatting:
The JSON file is newly added and appears to be well structured and valid. All keys follow a clear naming convention and the string values—including the use of newline characters and color formatting codes—are consistently applied, which should ensure proper parsing and display by the application.


2-6: Clear AimAssist Translations:
The translations for AimAssist (e.g. "description.wurst.hack.aimassist" and related settings) are concise and clearly communicate the intended functionality. They maintain the tone and technical accuracy needed for users.


7-16: Consistent Airplace and AnchorAura Block:
The keys and values for Airplace (lines 7–9) and AnchorAura (lines 10–16) demonstrate a consistent tone and clarity. The explanations include helpful details and warnings (using newline breaks) that align well with similar entries in other language files.


17-23: AntiAFK Translations Adequacy:
The AntiAFK-related entries (lines 17–23) are translated in a clear and informative manner. They properly explain both the functionality and the associated warnings (including the highlighted "ADVERTENCIA" with proper formatting).

Copy link

This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks.

Pull requests should be closed if:

  • They have been superseded by another pull request
  • They are out of scope or don't align with the project
  • They have become obsolete due to other changes
  • They have bugs or conflicts that won't be resolved

@prahzera
Copy link
Author

🤙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants