Skip to content

Conversation

nquesada
Copy link
Collaborator

@nquesada nquesada commented Oct 7, 2022

Scipy implements the generation of Haar random unitary and orthogonal matrices, thus there is no need to implement them internally.

@nquesada nquesada requested a review from sduquemesa October 7, 2022 14:52
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #731 (fb11e28) into master (9a9a352) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
- Coverage   98.33%   98.33%   -0.01%     
==========================================
  Files          78       78              
  Lines        9603     9602       -1     
==========================================
- Hits         9443     9442       -1     
  Misses        160      160              
Impacted Files Coverage Δ
strawberryfields/utils/random_numbers_matrices.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a9a352...fb11e28. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant