Skip to content

Conversation

amirelemam
Copy link
Contributor

@amirelemam amirelemam commented Jul 26, 2025

Summary
This PR solves the following issue:
Add remote module declarations to Module Federation example, which are critical for MF work properly.
These modules are necessary for the providers (turbo_home and turbo_settings).

Copy link

cla-assistant bot commented Jul 26, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jul 26, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Nsttt
Copy link
Member

Nsttt commented Jul 28, 2025

Hey @amirelemam can you please sign the SLA ?

Also another note, if possible can you upgrade the version of react-router to latest. The reason why it's failing its because they standarized the imports in the latest version 7 release.

Thank you !

@amirelemam
Copy link
Contributor Author

@Nsttt Thanks for your review!

  • I have signed the CLA
  • After upgrading to the latest react-router version (v7), I confirm the issue was fixed. I undid replacing the lib.

@amirelemam amirelemam changed the title fix(mf): add remotes + replace react-router w/ react-router-dom fix(mf): add remotes Aug 6, 2025
@zackarychapple zackarychapple merged commit edd2ad5 into ZephyrCloudIO:main Aug 6, 2025
5 of 6 checks passed
@zackarychapple
Copy link
Contributor

Summary This PR solves two issues:

  1. Add remote module declarations to Module Federation example, which are critical for MF work properly.
    These modules are necessary for the providers (turbo_home and turbo_settings).
  2. Replace react-router with react-router-dom
    The components imported are not present in react-router, but in react-router-dom instead.

Welcome and thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants