implementation of itk service for setting up the tests within particular SDKs#463
implementation of itk service for setting up the tests within particular SDKs#463kdziedzic70 wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a foundational ITK test orchestration service designed to streamline the execution of integration tests across multiple SDKs. It provides a robust, containerized environment for running concurrent test scenarios, enhancing the efficiency and reliability of cross-SDK compatibility testing. The service leverages FastAPI for its API and integrates with existing test utilities to manage agent clusters and report test outcomes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new FastAPI service (itk_service.py) designed to orchestrate and concurrently execute ITK test scenarios against a shared cluster, complete with API models for test cases and results. A new Dockerfile is added to build the service's Docker image, which includes installations for Go, Node.js, and Python dependencies managed by uv. Supporting files like .dockerignore, test_service.py, and test_service.sh are also added for environment setup and service testing. Additionally, the itk/test_suite is extended to support a 'current' agent type, with test_suite/current.py dynamically spawning either a Go or Python agent. A review comment suggests improving the RuntimeError message in test_suite/current.py to be more informative or to add a check for Docker environment usage.
| if not current_dir.exists(): | ||
| raise RuntimeError( | ||
| 'testing of current agent is available only in docker environment' | ||
| ) |
There was a problem hiding this comment.
2fb6b79 to
b403121
Compare
1b52c0b to
96cbdf2
Compare
96cbdf2 to
6b452a1
Compare
Description
PR contains implementation of dockerized itk service that will be helpful in running itk tests across different SDKs: it enables user to mount the "current" branch to container. Assuming that implementation of itk-tailored testing agent is rooted in the repository - user than may execute the tests of "current" version - against the "stable" sdks that are included in the docker.
CONTRIBUTINGGuide.Fixes #<issue_number_goes_here> 🦕