-
Notifications
You must be signed in to change notification settings - Fork 6
an idea to guess if files / dirs are in / output #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
an idea to guess if files / dirs are in / output #15
Conversation
|
Looks great! As you say, could you do this in one place either by adding a new parent class or a mixin? Secondly, could you add a simple test for this? I don't currently have a single place that I test the type inference, so I'd be happy for you to add a new top level test file, e.g. |
a2f2e79 to
87ed6cd
Compare
c29a8c1 to
d81e1f0
Compare
|
hooray .. tests are passing finally :) |
5142d63 to
e40300d
Compare
|
This is ready from my side. I added the functionality that in the fallback case the string is checked if there are numbers (int/float) and return CliInteger/CliFloat. |
|
I guess we should merge #25 first and rebase this PR afterwards. |
Okay I've merged it, feel free to pull master in this branch. |
guess its to unspecific
seems more useful when searching instead of matching
e40300d to
6e99ddc
Compare
|
Hmm, you've resolved a few comments that you haven't actually changed yet in the code. Did you forget to push some changes? |
and remove leftover debug print statement
a4c2b8d to
7aaac45
Compare
|
Any chance you could finish this PR @bernt-matthias? I think we got really close to it being done. If you don't have time I can try, but it might take a little to get my head around it. |
|
I have a bit of time this week. Then I'm offline for one more week. What's left to do? |
|
Hmm, good point. I could have sworn there was something left to do, but the issues are resolved and all the tests are passing so maybe not? I'll double check. |
|
Some minor suggestions but overall I think this looks good. |
89c1ede to
ced9191
Compare
ced9191 to
40fbc68
Compare
|
Perfect, thanks for this! |
Just a simple minded idea to distinguish input and output files and directories.
Could be realized by subclasses as well if preferred.
Btw. the regular expressions like
bool(ean)?,in(put)?, andout(put)?could be simplified by removing the optional part?