Skip to content

With requirement for fingerprint, we now need to build pyicu. #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

With requirement for fingerprint, we now need to build pyicu. #4498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ ENV PYTHONDONTWRITEBYTECODE 1
# https://scancode-toolkit.readthedocs.io/en/latest/getting-started/install.html
RUN apt-get update \
&& apt-get install -y --no-install-recommends \
build-essential \
bzip2 \
xz-utils \
zlib1g \
Expand All @@ -28,6 +29,8 @@ RUN apt-get update \
libgcrypt20 \
libpopt0 \
libzstd1 \
libicu-dev \
pkg-config \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

Expand Down
4 changes: 2 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ extractcode==31.0.0
extractcode-7z==16.5.210531
extractcode-libarchive==3.5.1.210531
fasteners==0.19
fingerprints==1.2.3
fingerprints==1.3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot upgrade fingerprints just yet, because they have removed support for python3.9, see https://github.com/opensanctions/fingerprints/blob/8eea92ff357e080c6c8bb0807352e7b5f83d9c14/pyproject.toml#L19C1-L19C28
This is not EOL yet: https://endoflife.date/python

Also why the tests are failing because we test and support python3.9.

Note also as mentioned in #4493 (comment), fingerprints is now unmaintained.
So we would want to consider switching to rigour in the future.

ftfy==6.3.1
future==1.0.0
gemfileparser2==0.9.4
Expand All @@ -40,7 +40,7 @@ license-expression==30.4.4
lxml==5.4.0
MarkupSafe==3.0.2
more-itertools==10.7.0
normality==2.6.1
normality==3.0.1
packageurl-python==0.17.1
packaging==25.0
packvers==21.5
Expand Down
Loading