Alterações feitas pelo WillHubner com algumas correções #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinaldoacdc
reviewed
Jan 2, 2023
|
|
||
| for prpRtti in typRtti.GetProperties do | ||
| begin | ||
| if not prpRtti.IsIgnore then |
Contributor
There was a problem hiding this comment.
Aqui o IsIgnore deixa de existir.
reinaldoacdc
reviewed
Jan 2, 2023
| aSQL := aSQL + ' order by ' + aPK + ' desc'; | ||
|
|
||
| case FSQLType of | ||
| Firebird: |
Contributor
There was a problem hiding this comment.
Ainda acho que poderia ter uma implementação para cada SqlType, mas resolve bem as issues,
reinaldoacdc
reviewed
Jan 2, 2023
Contributor
reinaldoacdc
left a comment
reinaldoacdc
left a comment
There was a problem hiding this comment.
Muito bacana, vou testar logo mais.
Algumas coisas poderiam ser diferentes, mas de uma forma geral eu gostei bastante.
Acho que o único problema é o de remover a lógica do "IsIgnore".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essa PR tem todas as alterações feitas pelo WillHubner, só precisei incluir a configuração de tipo de SQL em algumas funções de busca do SimpleDAO.
Segue a lista de commits feito pelo WillHubner: