Fix keystore ownership in Unifi deployment - unifi.sh for BSD #6447
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Neilpang this actually happened here 02da170 I suppose this was due to the failing Shellcheck test. Is there a way to check this before merging? There are a few people waiting for this, running acme.sh and Unify on OPNsense 😄 |
Member
|
please fix the format errors first |
Contributor
|
ShellCheck is suggesting to use find instead of ls because it handles non-alphanumeric characters better...
It's probably a great tool, but here ShellCheck is wrong @privacyfr3ak could you add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fix keystore ownership in Unifi deployment - unifi.sh on BSD systems
The "find" command behave differently on BSD. This cause the reading of folder and keystore ownership to fail and result in ownership not being changed. So I reverted to original version in this pull request. This seems to work on both BSD and Linux.