Consume complete message body even on error #3454
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschulze
force-pushed
the
bugfix/always-consume-message-body
branch
2 times, most recently
from
2181642 to
b498c65
Compare
gschulze
force-pushed
the
bugfix/always-consume-message-body
branch
from
b498c65 to
7da7390
Compare
|
Hey @robjtede, what are your thoughts on this? |
|
I've tried your patch on my local, but the issue remains. Please check again that the fix is actually valid, and add a regression test for this case somehow (I know it's challenging, though). |
|
@JohnTitor I remember having a thorough test setup one year ago when I investigated the issue. I need to check whether I can find the code from back then. |
|
i think the issue is related to #3715 where we've discussed and are testing a fix at the actix-http level, i think that supersedes this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Bug Fix
PR Checklist
Overview
Currently, if there is an error during an HTTP request, the message body is not completely consumed in
actix-web/src/types/payload.rs. In cases where HTTP keep-alive is enabled, this causes the connection to hang in theCLOSE-WAITstate, with the TCP receive queue still containing some bytes that need to be consumed. This PR modifies theFutureimplementation forHttpMessageBodyto always consume all available data and return with success or error at the end. Besides issue #3182, there might be similar issues that are resolved by this PR.Closes #3182