Added max_buffer_size as a configuration item on the httpservice #3662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
added
A-http
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Overview
No breaking changes.
This new feature allows the user to configure the max_buffer_size used by the http service dispatcher, rather than rely on a const value.
This is important to control the chunk size in streaming scenarios. For example, when streaming images in a multipart/x-mixed-replace, if the images are smaller than the const MAX_BUFFER_SIZE, they will buffer and affect the end-user's refresh rate. With this feature, the user can select a lower max_buffer_size and stream arbitrarily small chunks.