refactor launcher to use usb mouse library #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The similar PR to Minesweeper is adafruit/Adafruit_Learning_System_Guides#3118 |
|
Since we're requiring all apps to know about the override setting this needs to be updated or the boot animation will crash when used with an app that has overridden the volume. |
FoamyGuy
reviewed
Sep 16, 2025
FoamyGuy
reviewed
Sep 16, 2025
FoamyGuy
requested changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
I'm noticing that the Minesweeper app is hitting a USB crash fairly frequently now, but I don't think that has anything to do with this update, I think it has to do with the improved error handling in the core.
I'm going to submit a similar PR to the learning system to convert minesweeper to using the adafruit_usb_host_mouse library and if necessary update the response to usb errors from the core.