Fix: Add a11y to closed captions button and selector #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng preferred to 'click' listening
cahirodoherty-learningpool
requested review from
ethan-lp,
joe-allen-89,
lemmyadams and
oliverfoster
|
@oliverfoster We have a need for this a11y fix to be pushed into the component at v6.8.2 |
lemmyadams
approved these changes
Aug 15, 2025
ethan-lp
approved these changes
Aug 22, 2025
|
We've had a principle of not editing the mejs source file, so that it's easier to update without having to reapply and easier to see the modifications isolated. |
| visibility: visible; | ||
| } | ||
|
|
||
| &[style*="display: none"] { |
There was a problem hiding this comment.
If an element is display: none it is already visibility: hidden. I don't understand what any of this code is for. Could you clarify please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes isse #345
Fix