WIP: fix(backend-test): the validation should not return None - #669
WIP: fix(backend-test): the validation should not return None#669MitanOmar wants to merge 6 commits into
Conversation
MitanOmar
changed the title
| ): | ||
| return data | ||
| msg = "You don't have the permission to update this task" | ||
| msg = "You don't have the permission to update this task" # pragma: no cover |
There was a problem hiding this comment.
I'd rather see a test for this instead
There was a problem hiding this comment.
@winged i did not see tests in the beginning, that's why i did not wrote it, but for sure i can add,
and an important note: i see in the changes tab that the changes are only one file, but if you check f0785a2 commit, you will see that there are some snapshot updated, i would like to confirm this too please
There was a problem hiding this comment.
It's a change in behaviour, so I think there should be a test for it.
Regarding that commit, I think it's coming from the main branch as you merged main into this feature branch, so that's normal. Maybe try rebasing, then the diff should be less confusing
|
Just a couple questions:
:) |
Pull request was converted to draft
|
I tried to rebase this branch with main, but it's ended up with having 10K files in my changes list, so i am closing this, and i reopen a new branch in #1379 |
3 participants
No description provided.