S3Mock 5.0.0 #2453
Open
S3Mock 5.0.0 #2453
+13,087
−13,418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afranken
changed the title
afranken
force-pushed
the
spring-boot-4-snapshot
branch
2 times, most recently
from
96b0b36 to
bae04ef
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
afranken
force-pushed
the
spring-boot-4-snapshot
branch
3 times, most recently
from
9fe17d9 to
43f93c7
Compare
afranken
force-pushed
the
spring-boot-4-snapshot
branch
from
43f93c7 to
19d18e1
Compare
afranken
force-pushed
the
spring-boot-4-snapshot
branch
from
19d18e1 to
df27879
Compare
afranken
force-pushed
the
spring-boot-4-snapshot
branch
2 times, most recently
from
6452122 to
2647136
Compare
afranken
force-pushed
the
spring-boot-4-snapshot
branch
from
2647136 to
05dcfcf
Compare
afranken
force-pushed
the
spring-boot-4-snapshot
branch
2 times, most recently
from
ae3d683 to
89504f0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades S3Mock to version 5.0.0 with significant modernization and removal of deprecated components. The upgrade focuses on removing AWS SDK v1 support, dropping JUnit 4 compatibility, migrating utility classes to Kotlin, and updating to newer Spring Boot and framework versions.
- Removes AWS SDK for Java v1 dependencies and related code as it reaches end-of-support
- Eliminates JUnit 4 support module and references
- Updates property naming conventions to use consistent
com.adobe.testing.s3mock.store.*prefixes
Reviewed Changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Updates parent version to 5.0.0-SNAPSHOT, removes AWS SDK v1 dependencies, upgrades Spring Boot to 4.0.0-M2 |
| testsupport/pom.xml | Removes junit4 module from build |
| testsupport/common/pom.xml | Removes AWS SDK v1 dependency |
| testsupport/junit5/src/main/java/com/adobe/testing/s3mock/junit5/S3MockExtension.java | Removes AWS SDK v1 client support from parameter resolution |
| testsupport/common/src/main/java/com/adobe/testing/s3mock/testsupport/common/S3MockStarter.java | Removes deprecated AWS SDK v1 client creation methods, updates property constants |
| server/src/main/resources/application.properties | Updates property names to use new naming convention |
| server/src/main/kotlin/com/adobe/testing/s3mock/util/*.kt | Migrates utility classes from Java to Kotlin |
| server/src/main/java/com/adobe/testing/s3mock/S3MockApplication.java | Removes legacy property translation code |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...st/kotlin/com/adobe/testing/s3mock/util/AwsUnsignedChunkedDecodingChecksumInputStreamTest.kt
Show resolved
Hide resolved
afranken
force-pushed
the
spring-boot-4-snapshot
branch
3 times, most recently
from
6b0e93e to
b01627c
Compare
# Conflicts: # testsupport/junit4/src/main/java/com/adobe/testing/s3mock/junit4/S3MockRule.java
commons-io and commons-lang3 are not necessary when using Kotlin. :)
commons-io and commons-lang3 are not necessary when using Kotlin. :)
afranken
force-pushed
the
spring-boot-4-snapshot
branch
from
8334f77 to
9d79c93
Compare
server/src/main/kotlin/com/adobe/testing/s3mock/store/BucketStore.kt
Dismissed
Show dismissed
Hide dismissed
server/src/main/kotlin/com/adobe/testing/s3mock/store/BucketStore.kt
Dismissed
Show dismissed
Hide dismissed
Also adds serialization / deserialization tests for internal data structures BucketMetadata, S3ObjectMetadata and S3ObjectVersions
Add private backing field and public accessors to non-mutable versions.
Also: use Kotlin Regex, the API is simpler than Java's Pattern API.
Also, execute 20 requests in parallel instead of 100. Sometimes, the S3Mock ITs would fail with OOMs because they are configured to use only 256MB or ram, which is too low for 100 concurrent requests using Spring MVC without virtual threads or coroutines.
We now return all headers for get object calls with range.
We already configure kotlin.compiler.jvmTarget in the <properties>.
Sometimes, the default of 1 minute is not sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See
https://github.com/spring-projects/spring-boot/milestones
4.0.0-M3 -> SEPT-18
4.0.0-RC1 -> OCT-23
4.0.0 -> NOV-20
Related Issue
Tasks