Skip to content
Open

4.10.0 #2657

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,20 @@ Version 4.x is JDK17 LTS bytecode compatible, with Docker and JUnit / direct Jav
* Update to Spring Boot 3.5.7
* Planned release October 23rd 2025
* https://github.com/spring-projects/spring-boot/milestone/399
* Bump org.apache.commons:commons-lang3 from 3.18.0 to 3.19.0
* Version updates (build dependencies)
* TBD
* Bump digital.pragmatech.testing:spring-test-profiler from 0.0.12 to 0.0.13
* Bump org.mockito.kotlin:mockito-kotlin from 6.0.0 to 6.1.0
* Bump org.codehaus.mojo:exec-maven-plugin from 3.5.1 to 3.6.1
* Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.11.3 to 3.12.0
* Bump org.apache.maven.plugins:maven-compiler-plugin from 3.14.0 to 3.14.1
* Bump org.apache.maven.plugins:maven-dependency-plugin from 3.8.1 to 3.9.0
* Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.6.1 to 3.6.2
* Bump com.puppycrawl.tools:checkstyle from 11.0.1 to 11.1.0
* Bump github/codeql-action from 3.30.3 to 3.30.6
* Bump actions/dependency-review-action from 4.7.3 to 4.8.0
* Bump ossf/scorecard-action from 2.4.2 to 2.4.3
* Bump actions/stale from 10.0.0 to 10.1.0

## 4.9.1
Version 4.x is JDK17 LTS bytecode compatible, with Docker and JUnit / direct Java integration.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1336,6 +1336,24 @@ internal class GetPutDeleteObjectIT : S3TestBase() {
}
}

@Test
@S3VerifiedSuccess(year = 2025)
fun `GET object succeeds with unquoted if-match=true`(testInfo: TestInfo) {
val (bucketName, putObjectResponse) = givenBucketAndObject(testInfo, UPLOAD_FILE_NAME)
val matchingEtag = putObjectResponse.eTag()
// TODO: should work with both quoted and unquoted etags
val unquotedEtag = matchingEtag.substring(1, matchingEtag.length - 1)
s3Client
.getObject {
it.bucket(bucketName)
it.key(UPLOAD_FILE_NAME)
it.ifMatch(matchingEtag)
}.use {
assertThat(it.response().eTag()).isEqualTo(matchingEtag)
assertThat(it.response().contentLength()).isEqualTo(UPLOAD_FILE_LENGTH)
}
}

@Test
@S3VerifiedSuccess(year = 2025)
fun `GET object succeeds with if-match=true and if-unmodified-since=false`(testInfo: TestInfo) {
Expand Down Expand Up @@ -1407,6 +1425,24 @@ internal class GetPutDeleteObjectIT : S3TestBase() {
.hasMessageContaining("Service: S3, Status Code: 304")
}

@Test
@S3VerifiedSuccess(year = 2025)
fun `GET object fails with unquoted if-none-match=false`(testInfo: TestInfo) {
val (bucketName, putObjectResponse) = givenBucketAndObject(testInfo, UPLOAD_FILE_NAME)
val matchingEtag = putObjectResponse.eTag()
// TODO: should work with both quoted and unquoted etags
val unquotedEtag = matchingEtag.substring(1, matchingEtag.length - 1)

assertThatThrownBy {
s3Client.getObject {
it.bucket(bucketName)
it.key(UPLOAD_FILE_NAME)
it.ifNoneMatch(matchingEtag)
}
}.isInstanceOf(S3Exception::class.java)
.hasMessageContaining("Service: S3, Status Code: 304")
}

@Test
@S3VerifiedSuccess(year = 2025)
fun `GET object succeeds with if-modified-since=true`(testInfo: TestInfo) {
Expand Down