-
Notifications
You must be signed in to change notification settings - Fork 9
Preprod-building workflow: input PR number instead of branch name #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Marc-Andrieu
wants to merge
15
commits into
aeecleclair:main
Choose a base branch
from
aeecleclair:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtf am i doing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
=======================================
Coverage 85.89% 85.89%
=======================================
Files 193 193
Lines 14953 14953
=======================================
Hits 12844 12844
Misses 2109 2109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
The reason why
The new manually-triggered workflow to build&push pre-prods has a nice dropdown to select the pre-prod...
But the branch name had to be put in as a string.
Now you write the PR number.
Before/after comparison
Technical details
The best would have been a nice dropdown (with branch names or PR numbers, whatever) because this ensures no error is possible and the dev doesn't have to search information.
But I did not find how to run some command before/inside the top-level
onto generate the dropdown choices.Issues to be resolved
Required PRs
Changes Made
You'd better read the code for this one.
Additional Notes
Classification
Type of Change
Impact & Scope
Testing
Documentation