-
Notifications
You must be signed in to change notification settings - Fork 9
test script #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
test script #893
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
==========================================
+ Coverage 85.89% 90.21% +4.31%
==========================================
Files 193 229 +36
Lines 14953 22090 +7137
==========================================
+ Hits 12844 19928 +7084
- Misses 2109 2162 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fa63b95 to
a1dfa1a
Compare
Marc-Andrieu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very interesting PR.
Didn't test, but reviewed the code in detail : it's very well written and should work.
I left a couple comments for you on small things to improve
Description
Summary
This PR introduces a tests script so that module scope changes only will not run every test during CI. However, if any file outside module scope is modified, all the tests will run again.
Changes Made
Classification
Type of Change
🐛 Bug fix (non-breaking change which fixes an issue)
✨ New feature (non-breaking change which adds functionality)
🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
🔧 Infra CI/CD (changes to configs of workflows)
💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
😶🌫️ No impact for the end-users
Impact & Scope
Core functionality changes
Single module changes
Multiple modules changes
Database migrations required
Other:
Testing
1. Tested this locally
2. Added/modified tests that pass the CI
3. Tested in a pre-prod
0. Untestable (exceptionally), will be tested in prod directly
Documentation
Updated the docs accordingly :
"Docstrings#Inline commentsNo documentation needed