Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ if (NOT CMAKE_BUILD_TYPE)
endif (NOT CMAKE_BUILD_TYPE)

if (NOT DEFINED CMAKE_CXX_STANDARD)
set(CMAKE_CXX_STANDARD 11)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changed to C++ 14?
We can't accept this change, because there are existing customers on older C++ versions.

set(CMAKE_CXX_STANDARD 14)
endif ()

if (NOT DEFINED CMAKE_CXX_EXTENSIONS)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2630,9 +2630,9 @@ private void generateConstPropertyMethods(
values);

sb.append(String.format("\n" +
indent + " SBE_NODISCARD %1$s %2$s(const std::uint64_t index) const\n" +
indent + " SBE_NODISCARD static SBE_CONSTEXPR %1$s %2$s(const std::uint64_t index)\n" +
indent + " {\n" +
indent + " static const std::uint8_t %2$sValues[] = { %3$s, 0 };\n\n" +
indent + " const std::uint8_t %2$sValues[] = { %3$s, 0 };\n\n" +

indent + " return (char)%2$sValues[index];\n" +
indent + " }\n",
Expand Down
2 changes: 2 additions & 0 deletions sbe-tool/src/test/c/CodeGenTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ class CodeGenTest : public testing::Test
}

char code_buf[4];
memset(code_buf, 0, sizeof(code_buf));
CGT(engine) engine = {};
if (CGT(car_engine)(&car, &engine))
{
Expand Down Expand Up @@ -338,6 +339,7 @@ class CodeGenTest : public testing::Test
}

char code_buf[4];
memset(code_buf, 0, sizeof(code_buf));
CGT(engine) engine = {};
if (CGT(car_engine)(&car, &engine))
{
Expand Down
Loading