Adding "type" prefix before type operator imports#194
Merged
jespercockx merged 8 commits intoagda:masterfrom Jul 27, 2023
Merged
Adding "type" prefix before type operator imports#194jespercockx merged 8 commits intoagda:masterfrom
jespercockx merged 8 commits intoagda:masterfrom
Conversation
jespercockx
approved these changes
Jul 24, 2023
Member
jespercockx
left a comment
jespercockx
left a comment
There was a problem hiding this comment.
Thank you for the PR! I have two comments, but overall this seems like a useful improvement to have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHC expects that when importing type operators, the
typeprefix is provided before the identifier in the import specs. This PR fixes that. It only calculates this for operators; since for other identifiers it would only be needed when having a "normal" function with the same name, and Agda doesn't allow that.Unfortunately, when type operators have "children" imports (see
(***)inTypeOperatorImport.hs), you have to specify it too, but the Haskell Language Extensions' pretty printer does not do it. So I had to circumvent this; which has the side effect of it not being able to break long import lines anymore. (But see PR 475 there.)