Add _test_simple_multiple_platforms_with_extras
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartikainen
commented
Aug 3, 2025
Comment on lines
482
to
484
| # NOTE(hartikainen): Perhaps this is part of the problem? | ||
| # This should say `jax[cuda12]==0.7.0` for `linux_x86_64` platform and | ||
| # `jax==0.7.0` for `linux_arm64` and `osx_aarch64`. |
There was a problem hiding this comment.
My guess is that this points to the main issue. We should probably have two entries under wheel libraries because one of them evaluate to jax[cuda12] and the other two to just jax.
aignas
force-pushed
the
exp/pypi-simplify-freethreaded
branch
2 times, most recently
from
66c133d to
040f77e
Compare
aignas
force-pushed
the
exp/pypi-simplify-freethreaded
branch
from
040f77e to
849456e
Compare
Run with: ```console bazel test //tests/pypi/extension:test_simple_multiple_platforms_with_extras ```
hartikainen
force-pushed
the
bug/multiple-platforms-with-extras
branch
from
1e8ca06 to
392fece
Compare
These changes make `test_simple_multiple_platforms_with_extras` pass but I don't have enough understanding of the interdependencies here to say if this is the right solution.
This reverts commit c1aafac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in bazel-contrib#2797 (comment).