-
Notifications
You must be signed in to change notification settings - Fork 4
chore(deps): update dependency pyright to >=1.1.407,<1.1.408 #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Claude finished @renovate[bot]'s task —— View job Pyright Dependency Update Review -
|
2c871a5 to
d5a4d02
Compare
|
Claude finished @renovate[bot]'s task —— View job Pyright v1.1.407 Dependency Update Review - ❌ BLOCKING ISSUES FOUNDTodo List
Executive Summary❌ DO NOT MERGE - This PR updates Pyright to version 1.1.407, which contains a known regression causing 301 type checking errors across all GUI modules in the SDK. Critical Findings🚨 Type Checking Regression (BLOCKING)Issue: Pyright 1.1.407 has a regression with dataclass decorators (microsoft/pyright#11060) Impact: 301 errors across the codebase, all related to Verification: $ uv run pyright --version
pyright 1.1.407
$ uv run pyright src/aignostics
301 errors, 0 warnings, 0 informationsSample Errors: Root Cause:
Affected Modules:
Contradictory State in pyproject.tomlLine 161 contains a contradictory comment: "pyright>=1.1.407,<1.1.408", # Regression in 1.1.407, see https://github.com/microsoft/pyright/issues/11060The comment warns about the regression in 1.1.407, yet the version constraint includes 1.1.407. This should have been: "pyright>=1.1.406,<1.1.407", # Regression in 1.1.407, see https://github.com/microsoft/pyright/issues/11060Upstream StatusIssue: microsoft/pyright#11060
CI/CD ImpactAccording to
This PR will fail the lint stage because:
Recommendations✅ Immediate Action: Revert pyproject.toml changeUpdate line 161 from: "pyright>=1.1.407,<1.1.408", # Regression in 1.1.407, see https://github.com/microsoft/pyright/issues/11060To: "pyright>=1.1.406,<1.1.407", # Regression in 1.1.407 (fixed in 1.1.408+), see https://github.com/microsoft/pyright/issues/11060⏰ Future Action: Update when 1.1.408 is releasedWhen Pyright 1.1.408 appears on PyPI: "pyright>=1.1.408,<1.1.409", # Regression in 1.1.407 fixed in 1.1.408🤖 Renovate ConfigurationConsider adding to Renovate config to skip known-broken versions: {
"packageRules": [
{
"matchPackageNames": ["pyright"],
"allowedVersions": "!1.1.407"
}
]
}Why This Matters for Medical Device SoftwareThis SDK is used for computational pathology - a regulated medical device domain requiring:
Impact of merging:
Testing Performed# Confirmed regression exists
uv sync --all-extras
uv run pyright --version # Output: pyright 1.1.407
uv run pyright src/aignostics # Output: 301 errors
# Verified upstream fix merged but not yet released
# Checked PyPI - 1.1.407 is latest (no 1.1.408 yet)Conclusion❌ REJECT THIS PR This dependency update introduces 301 type checking errors due to a known Pyright regression. The fix is merged upstream but not yet released to PyPI as version 1.1.408. Required Actions:
|
|



This PR contains the following updates:
>=1.1.406,<1.1.407->>=1.1.407,<1.1.408Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
RobertCraigie/pyright-python (pyright)
v1.1.407Compare Source
Configuration
📅 Schedule: Branch creation - "before 2am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.