Skip to content

Conversation

danielhollas
Copy link
Collaborator

This is needed because otherwise ruff gets confused, see astral-sh/ruff#9298 for detailed explanation.

This allows us to get rid of bunch of noqa's. 🎉

Split from #6704

This is needed because otherwise ruff gets confused, see
astral-sh/ruff#9298
for detailed explanation.

This allows us to get rid of bunch of noqa's
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.20%. Comparing base (6afd3f5) to head (52c2513).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/aiida/orm/authinfos.py 0.00% 1 Missing ⚠️
src/aiida/orm/comments.py 0.00% 1 Missing ⚠️
src/aiida/orm/computers.py 0.00% 1 Missing ⚠️
src/aiida/orm/groups.py 0.00% 1 Missing ⚠️
src/aiida/orm/logs.py 0.00% 1 Missing ⚠️
src/aiida/orm/nodes/node.py 0.00% 1 Missing ⚠️
src/aiida/orm/users.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7019   +/-   ##
=======================================
  Coverage   79.20%   79.20%           
=======================================
  Files         567      567           
  Lines       43803    43803           
=======================================
  Hits        34691    34691           
  Misses       9112     9112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And indeed, overlaps with #7026

@danielhollas danielhollas merged commit ebc9d4a into aiidateam:main Sep 28, 2025
30 of 31 checks passed
@danielhollas danielhollas deleted the ruff-custom-generics branch September 28, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants