Update aiohttp dependency #16
Conversation
This change updates aiohttp to >= 0.22.1 and updates the code to the new APIs.
aiocouchdb/client.py
Outdated
|
|
||
|
|
||
| class HttpRequest(aiohttp.client.ClientRequest): | ||
| class HttpRequest(aiohttp.client_reqrep.ClientRequest): |
There was a problem hiding this comment.
please use just aiohttp.ClientRequest
|
@agentultra Hi |
|
@kxepal Understood... some of the APIs have changed quite a bit and I did my best on the first pass to keep things lined up. I'm working on a script that uses aiocouchdb with the aiobotocore library and they use conflicting versions of aiohttp. I'm here to help any way I can as I really need to get this working. |
This reverts commit df9ac9a.
Following up on some review comments I changed the HttpRequest and HttpResponse classes to subclass from aiohttp.ClientRequest and aiohttp.ClientResponse respectively. The lint check was catching an unused import in hdrs.py which I added a skip to since it's importing names into the module that are used elsewhere.
|
Any chance of this getting done? |
|
Oh, sorry! Yes, will handle this today. |
|
Thank you! I was originally going to fork and try to push something, but i saw that this was one Error shy of being merged. |
This comment has been minimized.
This comment has been minimized.
6 participants
This change updates aiohttp to >= 0.22.1 and updates the code to the new
APIs.