Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Oct 24, 2025

What do these changes do?

I optimized this one a bit too much assuming NETRC would always be set in #11634

fixes #11713

Are there changes in behavior for the user?

fix regression

Is it a substantial burden for the maintainers to support this?

no

I optimized this one a bit too much assuming NETRC would always be set in
#11634

fixes #11713
@bdraco bdraco added backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot labels Oct 24, 2025
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (1569ad9) to head (654d7e6).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11714   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         127      127           
  Lines       43549    43573   +24     
  Branches     2327     2327           
=======================================
+ Hits        43003    43027   +24     
  Misses        390      390           
  Partials      156      156           
Flag Coverage Δ
CI-GHA 98.63% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.36% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.69% <100.00%> (-0.01%) ⬇️
OS-macOS 97.58% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.15% <100.00%> (-0.01%) ⬇️
Py-3.10.18 97.65% <100.00%> (+<0.01%) ⬆️
Py-3.11.13 97.85% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.35% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 97.45% <100.00%> (+<0.01%) ⬆️
Py-3.12.11 97.95% <100.00%> (-0.01%) ⬇️
Py-3.13.7 97.95% <100.00%> (+<0.01%) ⬆️
Py-3.13.8 97.44% <100.00%> (+0.01%) ⬆️
Py-3.14.0 98.15% <100.00%> (-0.01%) ⬇️
Py-3.14.0t 97.23% <100.00%> (+<0.01%) ⬆️
Py-pypy3.10.16-7.3.19 90.54% <100.00%> (-2.96%) ⬇️
VM-macos 97.58% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.36% <100.00%> (+<0.01%) ⬆️
VM-windows 96.69% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 24, 2025

CodSpeed Performance Report

Merging #11714 will not alter performance

Comparing netrc_without_env_fix (654d7e6) with master (1569ad9)1

Summary

✅ 59 untouched

Footnotes

  1. No successful run was found on master (6a2809d) during the generation of this report, so 1569ad9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@bdraco bdraco marked this pull request as ready for review October 24, 2025 14:17
bdraco and others added 5 commits October 24, 2025 09:35
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The default .netrc file in the home directory is no longer used

2 participants