-
-
Couldn't load subscription status.
- Fork 2.1k
Fix loading netrc when NETRC env var is not set #11714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11714 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 127 127
Lines 43549 43573 +24
Branches 2327 2327
=======================================
+ Hits 43003 43027 +24
Misses 390 390
Partials 156 156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #11714 will not alter performanceComparing Summary
Footnotes |
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
for more information, see https://pre-commit.ci
…trc_without_env_fix
What do these changes do?
I optimized this one a bit too much assuming NETRC would always be set in #11634
fixes #11713
Are there changes in behavior for the user?
fix regression
Is it a substantial burden for the maintainers to support this?
no