Trying to add benchmarks but something is broken#1
Open
apiarian wants to merge 1 commit intoal3rez:masterfrom
Open
Trying to add benchmarks but something is broken#1apiarian wants to merge 1 commit intoal3rez:masterfrom
apiarian wants to merge 1 commit intoal3rez:masterfrom
Conversation
Time doesn't get formatted correctly, decimal seconds disappear, and something about the benchmarks results in null characters for the day of the month in the benchmarks.
Author
|
Also tests will fail in locales that are not UTC (Travis seems to be, but my Mac isn't). Something about the time being reported incorrectly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time doesn't get formatted correctly, decimal seconds disappear, and
something about the benchmarks results in null characters for the day of
the month in the benchmarks.
The one benchmark that does work so far shows a pretty hefty performance hit: